Bug Fix Problem with the vote Button Code...

xryskom

xryskom

Member
I'm having a problem with vote button generation
on my visio.
for example user name is UserName
so the CP will give me a link for voting
http://mysite.com/index.php?a=in&u=username
when i go to that link the site redirects me to main page and i cannot vote .
but if i manually change the link to
http://mysite.com/index.php?a=in&u=UserName
than it works and i'm getting to the gateway page .

How can i fix that?
Basically the vote code lowers the uppercase in username , thats the problem.
Or maybe i should disable uppercase in registration?
how do i do that?
 
Basti

Basti

Administrator
Staff member
Looks like voting username check is still case sensitive ( login was changed to insentive a while ago )

Odd thoough that the link code gives lower case username, never encountered that.
I will investigate and post back
 
Basti

Basti

Administrator
Staff member
I just tested this and i cannot reproduce your issue. Registered as "MyTest" and voting code turn out as "MyTest" also.

Do you use any plugins for voting code?
Seems like something on your list modifies this value
 
Mark

Mark

Administrator
Staff member
Did you edit this username or otherwise manipulate this users link code?

I have tested and can also not reproduce this issue, perhaps you can test again and provide exact steps to reproduce.
 
xryskom

xryskom

Member
Work method: Register with test1


Code: 
<a href="http://mysite.com/index.php?a=in&u=test1"><img src="http://mysite.com/button.php?u=test1&buttontype=static" alt="mysite.com" /></a>
Don't work method:


Code: 
<a href="http://mysite.com/index.php?a=in&u=test2"><img src="http://mysite.com/button.php?u=test2&buttontype=static" alt="mysite.com" /></a>
for see the vote page need to change http://mysite.com/index.php?a=in&u=test2 to /index.php?a=in&u=Test2
 
Basti

Basti

Administrator
Staff member
Disable each of your plugins and try again.
If there is still an issue after it ( means no plugin at fault ), please pm me or Mark site url and ftp info.

Would need to be debugged on your site, since we cant duplicate it.
 
Last edited:
Basti

Basti

Administrator
Staff member
Not sure what you want want to tell us with that. Like i said if disabling plugins not solve it, we need to look on YOUR site ( ftp ) in order to find the problem.
Sure we can enable that stuff to be non-sensitive, but that just moves the problem and not solves it all
 
Basti

Basti

Administrator
Staff member
Yes the problem is on your side
The problem is NOT that the vote username is case sensitive, the problem IS that your site spits out the wrong voting code for members.

Like i said you can make the vote link insensitive, but doesnt solve the issue to begin with. Thats not a correct way to handle a bug

the generator is not problem....
Click to expand...
You said otherwise yourself
I'm having a problem with vote button generation
on my visio.
for example user name is UserName
so the CP will give me a link for voting
http://mysite.com/index.php?a=in&u=username
Click to expand...
 
cajkan

cajkan

Active Member
Never had a problems like this, because you need to tell your users.

If you modify the code it might not work correctly.

They all need to do is to copy and paste code to their website.
 
xryskom

xryskom

Member
Why than you have the same issue on your demo or all other visio topsites? once you change the link the link doesnt work? All i want is links to work without sensetivity , both ways index.php?a=in&u=user or index.php?a=in&u=User or ever index.php?a=in&u=UsEr ..
 
Basti

Basti

Administrator
Staff member
I am not sure you understand yourself what the problem is
http://visiolist.com/community/threads/problem-with-the-vote-button-code.1679/#post-10709
According to that, your "Test1" gets a wrong voting code. That is a bug.

Why than you have the same issue on your demo or all other visio topsites?
Click to expand...
That is NO issue.
Again the issue is on YOUR list, that members get a wrong vote link to begin with. Join up on demo and you see "Test1" is "Test1", not like on your list.
Don't just change the url when you vote, that is entirely different thing.

the generator is not problem....need to rebuild the vote code and the system
Click to expand...
Clearly it is, on your site and your alone, the member gets a wrong voting html code. No one else encountered this issue before and no one can duplicate it.
Maybe you altered core code, maybe you have a bad plugin. That i can't tell unless looking at your files.

I told you before, provide us with ftp info and we gladly look why your member get wrong voting codes. If you don't want that, we can't help you.

Case insensitive is not bad, don't get me wrong. It is actually useful, just as it is for the login i mentioned in post #2
But changing that without fixing whatever it causes on your list, is big big mistake.
It's never good to walk around a bug and "fix" it by adjusting something. It may just lead to other problems, even if we add insensitivity.

Once your issue is taken care of, and it is an issue, clearly some bad code somewhere, feel free to open up a topic in the Core Feature Request section to have case insensitivity added.
But not until YOUR issue is fixed
 
Last edited:
xryskom

xryskom

Member
Okay so the vote code was depending on session logged in username, which was making issues on generation code if logged in with random cases.

For example if your original username is Noname , and you log in as NoNamE , the code generated would be generated for NoNamE instead of Noname . Which obviously makes a problem for users getting the right code .

So we fixed it , now no matter how the person logs in it will generate the code NOT depending on session , depending only on site owner data from the database.

ps. Before that we did not edit the core side of button/link code etc , so that small bug is still there at other visio sites , just keep in mind.

You may close the topic.
 
Mark

Mark

Administrator
Staff member
I will add this to the update list to investigate further, thanks for the report!
 
Basti

Basti

Administrator
Staff member
xryskom, the change you mentioned has been integrated into the login function, so the session username is the one who member registered with.
 
You must log in or register to reply here.
Top